Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: increase jest test timeout to prevent frequent test failure #4060

Closed
1 task
ravinderk opened this issue Mar 25, 2019 · 3 comments
Closed
1 task

fix: increase jest test timeout to prevent frequent test failure #4060

ravinderk opened this issue Mar 25, 2019 · 3 comments
Assignees

Comments

@ravinderk
Copy link
Collaborator

Feature Request

User Story

Currently, we are seeing on Travis that frontend test is failing and one of cause is timeout because on confirmation we are loading receipt via Ajax which takes more than 500ms few times. We can prevent the test from failing if we will increase time.

Visuals

image

ref: https://travis-ci.org/impress-org/give/jobs/510785400

Possible Solution

Set jest test interval to 500ms< for receipt paging tests.

Acceptance Criteria

  • All frontend test is passing without any timeout.
@ravinderk
Copy link
Collaborator Author

ravinderk commented Mar 29, 2019

I still see that the test is failing due to timeout. There was a performance issue with jest 24. currently, we are on 24.1.0. I will upgrade npm packages and then test again.

ref: jestjs/jest#7732

@ravinderk ravinderk reopened this Mar 29, 2019
@ravinderk
Copy link
Collaborator Author

Note: As we know that tests only fails for confirmation page on which receipt load by ajax. I did not find a function to set timeout value more than 500ms, so test still fails randomly.

@DevinWalker DevinWalker removed this from the Sprint: 2019/03/27 - 2019/04/09 milestone Apr 16, 2019
@ravinderk
Copy link
Collaborator Author

Closing this because it has been fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants