Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit type assertions #230

Closed
adityasaky opened this issue May 3, 2023 · 0 comments · Fixed by #327
Closed

Revisit type assertions #230

adityasaky opened this issue May 3, 2023 · 0 comments · Fixed by #327
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@adityasaky
Copy link
Member

@pxp928 pointed out in #228 that the codebase has a number of type assertions that aren't verified. As the implementation evolves to support more metadata types from the attestation framework, we may run into unexpected edgecases / panics. We should comprehensively revisit our assertions and add corresponding checks where necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant