You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Please fill in the fields below to submit an issue or feature request. The
more information that is provided, the better.
Description of issue or feature request:
I have read through some of the previous issues regarding this matter #46
I understand the idea behind only warning when a user command differs from an expected command. I am not proposing that we change this. All that I am proposing is adding a new optional parameter verify_command_alignment called regex that takes a string. If the regex is passed, we use that to perform a regex match. If they do not match, we print out a warning as we normally do.
I have already written this out in a branch and have written some unit tests to illustrate this.
I can change how we pass in the regex, but for now I thought to make expected_command optional as well as regex optional. I'm trying to thing of a better approach.
I'll add the documentation if you guys are ok with this. For now the PR is a draft #611
The text was updated successfully, but these errors were encountered:
aalsabag
pushed a commit
to aalsabag/in-toto
that referenced
this issue
Jun 15, 2023
Please fill in the fields below to submit an issue or feature request. The
more information that is provided, the better.
Description of issue or feature request:
I have read through some of the previous issues regarding this matter #46
I understand the idea behind only warning when a user command differs from an expected command. I am not proposing that we change this. All that I am proposing is adding a new optional parameter
verify_command_alignment
calledregex
that takes a string. If the regex is passed, we use that to perform a regex match. If they do not match, we print out a warning as we normally do.I have already written this out in a branch and have written some unit tests to illustrate this.
I can change how we pass in the regex, but for now I thought to make
expected_command
optional as well asregex
optional. I'm trying to thing of a better approach.I'll add the documentation if you guys are ok with this. For now the PR is a draft
#611
The text was updated successfully, but these errors were encountered: