Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saber parser slowing down site load times with high # variations #45

Open
atwellpub opened this issue Jul 11, 2014 · 1 comment
Open

Comments

@atwellpub
Copy link
Member

The Saber parser is slows down page load times significantly as variation count increases.

We reveal the correct variation via js after all variations have been prepared due to caching mechanisms preventing php from deciding which variation to preload.

We'll need to investigate a restructure of how we load ctas or build a faster parser.

For now this is not urgent.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@DavidWells
Copy link
Member

This would be fixed if we preprocess all the CSS and inline all of it with the correct classes.

So on CTA save, process all CSS to inline, save to cta and then render all 3 (if there are three variations) in the dom

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants