Fix past_booking_occurrences_are_cancelled test #6245
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If it was that easy, I'd have done it myself instead of opening an issue. The test is broken, so renaming it just enables it, now you need to actually fix it... :) |
|
Yes, I know. I was testing the changes on the CI. I should have opened as a draft PR. |
Fix past_booking_occurrences_are_cancelled test in bookings_test.py
sandipanpanda
force-pushed
the
fix-6210-past_booking_occurrences_are_cancelled-test
branch
from
0c32f9b
to
cea9094
Compare
|
For the request context error you can add FWIW, I was about that far when I decided to open an issue and continue working on something else... ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
past_booking_occurrences_are_cancelledtest in indico/modules/rb/operations/bookings_test.pyFixes: #6210