Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix file not found exception for Codeception Cests (from branch 0.21) #1503

Merged
merged 1 commit into from
Mar 31, 2021
Merged

Conversation

agilov
Copy link
Contributor

@agilov agilov commented Mar 31, 2021

For Codeception Cests there was TestFileNameNotFoundException because $fullyQualifiedClassName variable contains colon separated feature name but there is no .feature file in junit.xml report.

In junit.xml there is entries like so:

<testcase file="/app/modules/site/controllers/ExampleErrorController_Cest.php" name="test400" class="app\modules\site\controllers\ExampleErrorController_Cest" feature="test400" assertions="3" time="0.010310"/>

And $fullyQualifiedClassName is like this app\modules\site\controllers\ExampleErrorController_Cest:test400

I think there is no need to open the issue for such a small bug and I've fixed it in my vendor directory and propose the change via pull request.

@maks-rafalko
Copy link
Member

maks-rafalko commented Mar 31, 2021

Thanks for your work @agilov!

@maks-rafalko maks-rafalko merged commit cee1ab7 into infection:0.21 Mar 31, 2021
@maks-rafalko
Copy link
Member

@agilov agilov deleted the patch-2 branch March 31, 2021 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants