Trim "\n" and "\t" characters when replacing relative paths with absolute ones during XML config creation #1550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lute ones during XML config creation Fixes #1542
maks-rafalko
commented
Aug 9, 2021
| <testsuites> | ||
| <testsuite name="All Tests"> | ||
| <directory suffix="UnitTest.php"> | ||
| ./Tests |
There was a problem hiding this comment.
it's not visible here, but ./Tests is rounded by \n\t
sidz
approved these changes
Aug 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1542
When XML config contains "\n" or "\t" characters in the tag with paths, it breaks the path when Infection replaces relative paths with absolute ones.
Solution: just trim it.
Example of the problematic
phpunit.xml:https://github.com/alexdodonov/mezon-router/blob/dea1e597aba3dbd86148b9e9fc129048530c3280/phpunit.xml#L13-L15
Reason of the bug in debugger: