Avoid parser bugs for very large negative numbers #1580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanmai
changed the title
maks-rafalko
approved these changes
Sep 19, 2021
|
@maks-rafalko It looks like there's a requirement for CI jobs that no longer run, or run under a different name. Can you see? |
|
that's very strange and looks like some bug TBH in GH Actions. I disabled them for now in required checks |
|
Thank you @sanmai |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another take on the problem #1574, born after discussion in #1579.
Here we completely dodge any parser issues by refusing to increment
-9223372036854775807which is-PHP_INT_MAX.If we try to increment
-PHP_INT_MAXwe'll get a very fully looking contraption from PHP Parser:Fixes #1574
Related: php/doc-en@b3e793a