Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Inconsistent configuration file name #1679

Merged
merged 1 commit into from
Apr 4, 2022
Merged

fix: Inconsistent configuration file name #1679

merged 1 commit into from
Apr 4, 2022

Conversation

nhedger
Copy link
Contributor

@nhedger nhedger commented Apr 3, 2022

Fixes #1678

This PR fixes #1678 by replacing the filename we say we created (infection.json.dist) with the one that actually gets created (infection.json).

The correct file name is inferred from the saveConfig method, where SchemaConfigurationLoader::DEFAULT_CONFIG_FILE is used.

file_put_contents(
SchemaConfigurationLoader::DEFAULT_CONFIG_FILE,
json_encode($configObject, JSON_PRETTY_PRINT | JSON_UNESCAPED_SLASHES)
);

Copy link
Member

@sanmai sanmai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

Copy link
Member

@maks-rafalko maks-rafalko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @nhedger

@maks-rafalko maks-rafalko merged commit 5b8294c into infection:master Apr 4, 2022
@nhedger nhedger deleted the fix/configuration-file-name branch April 4, 2022 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect message after Infection configures its config
3 participants