Skip analysis when no executed lines with --git-diff-lines option
#1688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romm
force-pushed
the
fix/skip-analysis-when-no-lines-executed-in-git-diff-lines-mode
branch
from
48e58b0
to
4774c54
Compare
maks-rafalko
approved these changes
May 6, 2022
| { | ||
| public static function create(): self | ||
| { | ||
| return new self('No files in diff found, skipping mutation analysis.'); |
There was a problem hiding this comment.
Suggested change
| return new self('No files in diff found, skipping mutation analysis.'); | |
| return new self('No covered lines in in diff found, skipping mutation analysis.'); |
or something similar, because the current error message is from another exception :)
There was a problem hiding this comment.
Yeah I kept the message on purpose because I thought it made sense in this situation as well, but there is a slight difference indeed. Thanks for the review!
When using the `--git-diff-lines` option, there are situations where a file can be modified but will not yield any test change, for instance when only a comment is modified in a PHP source file. This commit prevents an error being thrown when this very situation occurs; instead, the analysis is skipped.
romm
force-pushed
the
fix/skip-analysis-when-no-lines-executed-in-git-diff-lines-mode
branch
from
4774c54
to
eadbd4e
Compare
|
Thank you @romm |
romm
deleted the
fix/skip-analysis-when-no-lines-executed-in-git-diff-lines-mode
branch
|
Released as https://github.com/infection/infection/releases/tag/0.26.9 Enjoy! |
|
That was fast! thank you!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
When using the
--git-diff-linesoption, there are situations where afile can be modified but will not yield any test change, for instance
when only a comment is modified in a PHP source file.
This commit prevents an error being thrown when this very situation
occurs; instead, the analysis is skipped.