Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for json5 configuration file format #1727

Merged
merged 4 commits into from
Sep 15, 2022
Merged

Conversation

maks-rafalko
Copy link
Member

@maks-rafalko maks-rafalko commented Sep 10, 2022

  • Keep support for json to be backward-compatible with previous versions
  • Generate json5 by default for new projects

Closes #1724

Detailed feature request in #1724

* Keep support for `json` to be backward-compatible with previous versions
* Generate `json5` by default for new projects

Closes #1724
@maks-rafalko maks-rafalko added this to the next milestone Sep 10, 2022
@maks-rafalko
Copy link
Member Author

maks-rafalko commented Sep 14, 2022

Just in case you forgot @sanmai, waiting for your review :) Thanks

@maks-rafalko maks-rafalko merged commit b66257a into master Sep 15, 2022
@maks-rafalko maks-rafalko deleted the feature/json5 branch September 15, 2022 07:58
@maks-rafalko
Copy link
Member Author

Thank you, @sanmai

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support json5 format for configuration file, in addition to json
2 participants