Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider replacing the generator template engine with plop #2443

Open
joshuayoes opened this issue May 22, 2023 · 3 comments
Open

Consider replacing the generator template engine with plop #2443

joshuayoes opened this issue May 22, 2023 · 3 comments
Labels
cookbook 🧑‍🍳 A request on how a specific library or pattern would be implemented within an Ignite project enhancement

Comments

@joshuayoes
Copy link
Contributor

joshuayoes commented May 22, 2023

One of the nice features of Ignite is being able to use EJS to create components via the CLI.

However, the current implementation has a few drawbacks:

  • CLI commands cannot accept new props without a release
  • The CLI is coupled to existing folders

See plop library for more info https://github.com/plopjs/plop

Pros of moving to plop:

  • generator commands live in project and can change with time instead of being tied to boilerplate structure
  • The project seems more mature, more features, more docs
  • plop seems to have feature parity with ignite generators
  • easier to maintain since it is an external library

Cons of moving to plop:

  • we do not maintain it, so if we need different things, we can't control the source code
  • upfront cost of extra work to implement existing functionality
@joshuayoes
Copy link
Contributor Author

Originally suggested here #2317 (comment)

@joshuayoes
Copy link
Contributor Author

Some issues that are prompting this:

Historically, it appears the generator functionality has been the source of 100+ issues, not an insignificant source of maintenance cost: https://github.com/infinitered/ignite/issues?q=is%3Aissue+generate+generator

@frankcalise frankcalise added the cookbook 🧑‍🍳 A request on how a specific library or pattern would be implemented within an Ignite project label May 26, 2023
@frankcalise
Copy link
Contributor

Team met on this topic and will first do a cookbook version for test runs before thinking about incorporating it into Ignite

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cookbook 🧑‍🍳 A request on how a specific library or pattern would be implemented within an Ignite project enhancement
Projects
None yet
Development

No branches or pull requests

2 participants