Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any way to better handle multi-modules test execution in IDEA? #392

Open
szpak opened this issue Mar 20, 2023 · 1 comment
Open

Any way to better handle multi-modules test execution in IDEA? #392

szpak opened this issue Mar 20, 2023 · 1 comment
Labels
comp:infinitest-intellij Issues related to Infintest for IntelliJ (and other Jetbrains IDEs)

Comments

@szpak
Copy link
Contributor

szpak commented Mar 20, 2023

Is your feature request related to a problem? Please describe.
This may be challenging and I even don't have a good idea how it could look like. Nevertheless, I will describe the current situation.

Let's image a project with over a dozen modules. Some bigger change (e.g. a refactoring) affects more than one module. Infinitest executes the modules one by one. The first module is green. The second is red. The third is green.

The end status in the Infinitest tool window (both the icon and in the result tab) is "Ran X Tests - All Pass". Which is true just for the last module (and accidentally for the first one). The failure from the second module is ignored (overridden).

Describe the solution you'd like
I don't have any good idea. Some random thoughts:

  1. The end status for "multi-module execution" (the tests execution for a few modules sequentially) is combined and any failure causes the final result to be "failure". This is problematic as most likely Infinitest work on the module level and doesn't have a concept of the "multi-module test execution". In addition the reporting "Ran X Tests..." and the notification "balloons" would need to be adjusted.
  2. ?
@gtoison
Copy link
Contributor

gtoison commented Mar 21, 2023

One way to think about it is how incremental compilation works in terms of user feedback. Infinitest tries to be incremental and only runs the tests impacted by the changes.
Let's say you're starting with 2 compilation errors. Now you make a change and you have 3. Your IDE won't tell you "Code compiled, one more error", it will tell you "I compiled the code, you can have a look at the errors somewhere".

So maybe the status should be "Ran X tests - Some tests failed"

@gtoison gtoison added the comp:infinitest-intellij Issues related to Infintest for IntelliJ (and other Jetbrains IDEs) label Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:infinitest-intellij Issues related to Infintest for IntelliJ (and other Jetbrains IDEs)
Projects
None yet
Development

No branches or pull requests

2 participants