New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CircleCI hangs on Parcel build when Sass is imported into components #4055
Comments
Still happening. See https://circleci.com/gh/influxdata/chronograf/14247 for example. |
@jaredscheib @alexpaxton and I narrowed down the issue. Parcel appears to hang forever when attempting to build components that import a Sass file.
We are currently using the latter solution above as a stop gap until we decide upon on a more final solution. |
While this issue is solved, in part, with the stop gap implemented above; it is not ideal. The shift to moving the stylesheets to the component folder isn't just a folder structure change but was instead a step towards allowing our build process to automatically namespace class names per their component. The goal is to import the stylesheets into the components and access them as objects in our className props. In order to implement this, Parcel will need to support the scss files imports and our build process will need to include a function to prepend the component name to each class name when compiling our bundled stylesheet. |
I'm reluctant to open an issue unless I have a concrete reproduction. It also seems that the parcel maintainers are aware of Sass related issues—see this comment, for example. I would say let's give this a few weeks to fix itself. Importing Sass inside components vs. inside @mavarius Let's talk at some point about scoped CSS. There's quite a few varieties of scoped CSS out there that function differently. We also need to figure what place it has in Chronograf 1.x vs. 2.x vs. an external reusable UI package. |
By the way, I did attempt once more this morning to make the issue reproducible outside of our CircleCI environment. Even running the same exact same Docker image used in our CI worked fine on my local machine. I was able to narrow it down to a single problematic file, |
From #4043 circle build failing currently:
The text was updated successfully, but these errors were encountered: