New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unmaintained 'wee_alloc' #613

Closed

jdstrand opened this issue Nov 17, 2022 · 1 comment · Fixed by #614

jdstrand commented Nov 17, 2022 •

edited

GHSA-rc23-xxgq-x27g lists wee_alloc as unmaintained. https://github.com/influxdata/flux-lsp/blob/master/Cargo.toml#L60 lists it as optional and it is enabled with --feature=wee_alloc. AFAICS, --feature=wee_alloc is not used on its own, but wee_alloc is pulled in via --feature=wasm (see https://github.com/influxdata/flux-lsp/blob/master/Cargo.toml#L21) and https://github.com/influxdata/flux-lsp/blob/master/wasm-build.sh#L12 pulls this in as part of the release build.

As such, it would be good to migrate to a supported crate. I've heard but not tested that the std lib has a wasm allocator now (https://www.reddit.com/r/rust/comments/x1cle0/comment/imde3cl/?utm_source=reddit&utm_medium=web2x&context=3).

References:

The text was updated successfully, but these errors were encountered:

wiedld mentioned this issue

chore(613): replace unmaintained wee_alloc with dlmalloc #614

Merged

wiedld closed this as completed in #614

Author

jdstrand commented Nov 21, 2022

Thanks for fixing this @wiedld! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment