Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1 shell] Shell does not properly clean up the terminal #441

Closed
elyscape opened this issue Aug 23, 2022 · 2 comments · Fixed by #462
Closed

[v1 shell] Shell does not properly clean up the terminal #441

elyscape opened this issue Aug 23, 2022 · 2 comments · Fixed by #462

Comments

@elyscape
Copy link

When quitting the InfluxQL shell, it doesn't properly clean up the terminal. This results in the user needing to run stty sane in order to restore proper functioning of their terminal (e.g. echo of keys typed).

Steps to reproduce:

  1. Run influx v1 shell
  2. Type quit to quit
  3. Enter a new command on the command line

Expected behavior:
The terminal behaves as it did prior to launching influx v1 shell.

Actual behavior:
Typed characters are not echoed to the console.

Environment info:

  • System info:
    • Darwin 21.6.0 arm64
    • Linux 5.15.56-v8+ aarch64
  • Influx version:
    • macOS: Influx CLI 2.4.0 (git: 5c7c34f16d) build_date: 2022-08-18T18:21:50Z
    • Linux: Influx CLI 2.4.0 (git: 5c7c34f) build_date: 2022-08-18T19:26:48Z

Root cause:
This happens due to c-bata/go-prompt#228 (see my comment for an explanation). A fix is available in c-bata/go-prompt#263.

@elyscape
Copy link
Author

I went ahead and opened influxdata/go-prompt#1 to get the fix into your fork of go-prompt.

@elyscape
Copy link
Author

elyscape commented Nov 9, 2022

Pinging @candrewlee14 and @lesam, who worked on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant