Positional Args break when using Hashes

[kornypoet]

Positional arguments break when the last argument is a Hash:

# This does not work as expected
class Foo
  include Gorillib::Model

  field :name, String, position: 0
  field :info, Hash, position: 1
end

f = Foo.new('joebob', { boring: true })
f.name
#=> "joebob"
f.info
#=> nil

This can be solved by either not having a Hash as the last positional argument, or by passing in the (apparently not optional) options hash whenever using the #new method with positional args. Neither is a great alternative:

# Never put Hashes last in positional argument lists
class Foo
  include Gorillib::Model

  field :name, String, position: 1
  field :info, Hash, position: 0 # Reorganize the positions to avoid problems
end

f = Foo.new({ boring: true }, 'joebob')
f.name
#=> "joebob"
f.info
#=> {:boring=>true}

# Or alternatively

class Foo
  include Gorillib::Model

  field :name, String, position: 0
  field :info, Hash, position: 1
end

f = Foo.new('joebob', { boring: true }, {}) # Always remember this empty options hash
f.name
#=> "joebob"
f.info
#=> {:boring=>true}

The culprit is the #extract_options! method here.