Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polish ci:build, ci:build:image, and ci:build:compose #890

Open
5 of 11 tasks
make-github-pseudonymous-again opened this issue Apr 17, 2024 · 0 comments
Open
5 of 11 tasks

Polish ci:build, ci:build:image, and ci:build:compose #890

make-github-pseudonymous-again opened this issue Apr 17, 2024 · 0 comments
Labels
ci This issue is about continuous integration docker This has to do with docker images and containers dx This is about developer experience
Projects
CI/Docker sprint

Comments

@make-github-pseudonymous-again
Copy link
Contributor

  • Choose between localhost and 127.0.0.1.
  • Refactor nc loop as composite action.
  • Refactor docker inspect .State loop as composite action.
  • Refactor docker inspect .State.Health loop as composite action.
  • Refactor docker container IP address retrieval step as a composite action.
  • Remove unnecessary steps: repeated docker container logs, docker ps -a, ls/cat, ...
  • Add name with emoji to each step.
  • Harmonize docker container names.
  • Check Node and NPM's version in all workflows.
  • Check that server is properly killed by SIGTERM in ci:build test job.
  • Check if setting up buildx allows to docker run to use --health-start-interval.
@make-github-pseudonymous-again make-github-pseudonymous-again added ci This issue is about continuous integration dx This is about developer experience docker This has to do with docker images and containers labels Apr 17, 2024
Merged
7 tasks
@make-github-pseudonymous-again make-github-pseudonymous-again moved this from To Do to In Progress in CI/Docker sprint Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ci This issue is about continuous integration docker This has to do with docker images and containers dx This is about developer experience
Projects
CI/Docker sprint
In Progress
Milestone
No milestone
Development

No branches or pull requests
1 participant
@make-github-pseudonymous-again