You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The latest change from sovereign-sdk-wip discourages creating custom Context while creating a token within ibc-transfer module. Context is only meant for transaction execution context.
Earlier, a new TokenId was created from a deterministic function of the transaction sender address, a token name, and a salt. But the IBC TokenIds should not use relayer (on-recv packet submitter) address - rather use ibc-transfer ModuleId address. So, the hack was replacing the current Context with a custom one by setting the sender to ibc-transfer module address.
The latest sovereign-sdk-wip removes this restriction by taking a impl Payable<S> instead of Context. We should use this to pass ibc-transfer's ModuleId::to_payable().
ref: Sovereign-Labs/sovereign-sdk-wip#573
The text was updated successfully, but these errors were encountered:
The latest change from sovereign-sdk-wip discourages creating custom
Context
while creating a token within ibc-transfer module.Context
is only meant for transaction execution context.sovereign-ibc/modules/sov-ibc-transfer/src/context.rs
Lines 203 to 220 in 00e8d18
Earlier, a new
TokenId
was created from a deterministic function of the transaction sender address, a token name, and a salt. But the IBCTokenId
s should not use relayer (on-recv packet submitter) address - rather use ibc-transferModuleId
address. So, the hack was replacing the currentContext
with a custom one by setting the sender to ibc-transfer module address.The latest sovereign-sdk-wip removes this restriction by taking a
impl Payable<S>
instead ofContext
. We should use this to pass ibc-transfer'sModuleId::to_payable()
.ref: Sovereign-Labs/sovereign-sdk-wip#573
The text was updated successfully, but these errors were encountered: