Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infallible impl Payable conversion from byte arrays #157

Closed
rnbguy opened this issue May 7, 2024 · 0 comments · Fixed by #154
Closed

infallible impl Payable conversion from byte arrays #157

rnbguy opened this issue May 7, 2024 · 0 comments · Fixed by #154

Comments

@rnbguy
Copy link
Member

rnbguy commented May 7, 2024

The latest changes in sovereign-sdk-wip makes Spec::Address conversion from arbitrary-sized byte array fallible.

We were using this to create escrow addresses corresponding to all ics20 channels in ibc-transfer module.

To keep this escrow address creation infallible across all Spec implementations, we need to create something else - that implements Payable<Spec>.

A suggestion from sovereign-sdk team is to use ModuleId - which offers infallible conversion from arbitrary-sized byte array and also implements Payable<Spec>.

ref: Sovereign-Labs/sovereign-sdk-wip#547

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

1 participant