Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

latest changes from sdk-wip #161

Merged
merged 31 commits into from
May 23, 2024
Merged

latest changes from sdk-wip #161

merged 31 commits into from
May 23, 2024

Conversation

rnbguy
Copy link
Member

@rnbguy rnbguy commented May 21, 2024

Closes: #158

Syncs until Sovereign-Labs/sovereign-sdk-wip@fc1552b44acddc2674a783cd11f301a8b79cc4f3

Description


PR author checklist

  • Linked to GitHub issue.
  • Added tests.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

@rnbguy
Copy link
Member Author

rnbguy commented May 21, 2024

Currently stuck because our test setup uses async runtimes - which requires the MockRollup to be Sync. But Sovereign-Labs/sovereign-sdk-wip#694 introduced Credentials which uses Arc<dyn core::any::Any> which is not bound by Send + Sync.

@rnbguy
Copy link
Member Author

rnbguy commented May 22, 2024

I managed to compile the code, but the tests are failing. Possibly, the mock chains are not initialized with a proper genesis state.

@rnbguy
Copy link
Member Author

rnbguy commented May 22, 2024

Managed to get the tests passed. ProverStorage is now immutable via Sovereign-Labs/sovereign-sdk-wip#613. Needed SimpleStorageManager to persist changes between batches.

@rnbguy
Copy link
Member Author

rnbguy commented May 22, 2024

The only thing is remaining is the cw-check. It is failing with a nix error.

@soareschen, @ljoss17 any idea how I fix the nix error? You can locally reproduce the error by:

nix build .#sov-celestia-cw

@soareschen
Copy link
Collaborator

The only thing is remaining is the cw-check. It is failing with a nix error.

@soareschen, @ljoss17 any idea how I fix the nix error? You can locally reproduce the error by:

nix build .#sov-celestia-cw

The Cargo.lock file and the git dependency hash needs to be updated, which you can see from the error log. I have pushed the fix.

@rnbguy
Copy link
Member Author

rnbguy commented May 22, 2024

Thanks so much ! I am still onboarding to nix, so I was confused with the error.

So, the Cargo.lock file needs to stay in sync. I shouldn't update it to the latest crate versions. Gotcha !

@rnbguy rnbguy marked this pull request as ready for review May 23, 2024 08:25
@rnbguy rnbguy merged commit 9cbeda8 into main May 23, 2024
11 checks passed
@rnbguy rnbguy deleted the rano/sdk-wip-catch-up branch May 23, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

avoid bare WorkingSet usage
2 participants