fix: lion-checkbox-indeterminate initial state closes #1967 #1983
Conversation
MiB-1
requested review from
tlouisse,
daKmoR,
gerjanvangeest,
erikkroes,
ruphin,
narzac,
Knorgias,
whenlit and
DannyMoerkerke
as code owners
🦋 Changeset detectedLatest commit: 6d4670e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
vignesh seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
MiB-1
changed the title
|
hi @gerjanvangeest, all the tests are passing, but not on time. is there anything that I can do to make it work? |
|
I think the CLA is not working since you pushed the changes as "vignesh" while your user name is "MiB-1". I need to dive into why the tests are failing. |
|
thanks. now I'll push with username with the new test. but can't understand what exactly needs to be tested. could you please explain a bit here? |
|
"Having the |
|
Thanks @gerjanvangeest. I found the issue I'm not doing |
…rminate closes #1967
What I did
lion-checkbox-indeterminatewith some initial checked child checkbox, it is not showing the expected state initially by adding a async function solves this issue.