Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

lion switch missing super call in disconnectedcallback #2045

Closed
iceicerickert opened this issue Jul 24, 2023 · 1 comment
Closed

lion switch missing super call in disconnectedcallback #2045

iceicerickert opened this issue Jul 24, 2023 · 1 comment

Comments

@iceicerickert
Copy link
Contributor

Hi! 馃憢

Firstly, thanks for your work on this project! 馃檪

Today I used patch-package to patch @lion/switch@0.16.5 for the project I'm working on.

Here is the diff that solved my problem:

diff --git a/node_modules/@lion/switch/src/LionSwitch.js b/node_modules/@lion/switch/src/LionSwitch.js
index b5b755e..e197147 100644
--- a/node_modules/@lion/switch/src/LionSwitch.js
+++ b/node_modules/@lion/switch/src/LionSwitch.js
@@ -94,6 +94,7 @@ export class LionSwitch extends ScopedElementsMixin(ChoiceInputMixin(LionField))
   }
 
   disconnectedCallback() {
+    super.disconnectedCallback();
     if (this._inputNode) {
       this._inputNode.removeEventListener(
         'checked-changed',

This issue body was partially generated by patch-package.

@gerjanvangeest
Copy link
Member

Sorry for the slow reaction :(

This has been fixed in @lion/ui some time ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants