Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lion-input-file should revoke created object URL's or dev should be warned that they might need to revoke the URL #2269

Open
Joel-Levi opened this issue Apr 19, 2024 · 0 comments

Comments

@Joel-Levi
Copy link
Contributor

I am using the lion-input-file for the image upload part of a rich text editor. The page this editor is on can be open for a long time, say an entire day.

When choosing a file using lion-input-file an object URL is created in the FileHandle. This object URL is never revoked within lion code, which means there is a memory leak happening.

I am not sure if the component itself can know when the URL may be revoked. If the revoking of the URL cannot safely be done in the components that are using the FileHandle class, developers should be informed that they might need to revoke the downloadUrls themselves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant