Make << in comment text parse correctly #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inside comments two consecutive less-than characters (`<<`) parsed wrongly as `<!`, due to what was probably a typo. This fixes that. Added regression test. Fixes inikulin#325.
inikulin
approved these changes
Oct 1, 2020
|
@anko thank you! |
|
Could a patch version be published with this fix? I may be the only person on the planet routinely parsing shell scripts containing |
anko
added a commit
to anko/txm
that referenced
this pull request
Nov 24, 2021
Did this myself because I guess hell will freeze over before anyone releases my merged parse5 bugfix PR. (╯°□°)╯︵ ┻━┻ inikulin/parse5#326 So shell heredocs will work inside comments now. Closes #4. It's nice to get rid of a big dependency too, and to avoid the runtime cost of doing full HTML parsing when we only needed the comments. And now we have line numbers and helpful error messages for unclosed comments.
jmbpwtw
pushed a commit
to jmbpwtw/parse5
that referenced
this pull request
Feb 16, 2023
Inside comments two consecutive less-than characters (`<<`) parsed wrongly as `<!`, due to what was probably a typo. This fixes that. Added regression test. Fixes inikulin#325.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inside comments two consecutive less-than characters (
<<) parsed wrongly as<!, due to what was probably a typo. This fixes that.Also added regression test.
Fixes #325.