Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CommonJS output #379

Closed
fb55 opened this issue Jan 14, 2022 · 1 comment · Fixed by #418
Closed

Add CommonJS output #379

fb55 opened this issue Jan 14, 2022 · 1 comment · Fixed by #418

Comments

@fb55
Copy link
Collaborator

fb55 commented Jan 14, 2022

As discussed in #351, we should make parse5 a hybrid module, with both ESM and CommonJS entry points.

@wooorm
Copy link
Collaborator

wooorm commented Jan 14, 2022

Not voting against it, but I am slightly against it ;)

(there’s been a lot of arguments in many places in favor and against ESM / dual / CJS, so I thought I’d just skip to my conclusion rather than rehashing everything again)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants