fix(rewriting-stream): Don't escape text in special tags #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. Thank you! |
|
cc @alan-agius4 @clydin as the last contributors to Angular's rewriting stream code: The Angular team uses the rewriting stream; as probably the main consumer of this: Is the possibility of text escaping its container (see question above) a concern for you? |
|
@fb55, I don’t think this is a problem at all. |
Awesome, thanks for confirming. |
jmbpwtw
pushed a commit
to jmbpwtw/parse5
that referenced
this pull request
Feb 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #339
Question: This allows users to leak data from tags. Eg. inserting the text
</script> foowould close the current script tag. There is no good solution that works for all special tags, and I'm not even sure this is an issue.cc @nfriedly — I'd love to hear your take on this.