fix(parser): Keep html and body end locations
#436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, we override the end locations for `html` and `body` tags on EOF. This isn't the most elegant solution, so happy for any suggestions of how to improve things.
fb55
added a commit
that referenced
this pull request
Mar 7, 2022
For some reason, we were escaping the data before. That meant we would only assert once that the received string matched the input. Now, we properly walk the tree (depth first, from the deepest node), and test nodes along the way. Requires #436
jmbpwtw
pushed a commit
to jmbpwtw/parse5
that referenced
this pull request
Feb 16, 2023
Before, we overrode the end locations for `html` and `body` tags on EOF. `body` will now take the end position from a closing `html` tag, if there was no closing `body` tag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we override the end locations for
htmlandbodytags on EOF.bodywill now take the end position from a closinghtmltag, if there was no closingbodytag.This isn't the most elegant solution, so happy for any suggestions of how to improve things.