Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Outlook VML statements become commented #963

Open
markb-trustifi opened this issue Jun 26, 2023 · 1 comment
Open

Outlook VML statements become commented #963

markb-trustifi opened this issue Jun 26, 2023 · 1 comment

Comments

@markb-trustifi
Copy link

markb-trustifi commented Jun 26, 2023 •
edited

version: 7.1.2

This html is parsed as a single comment node:

<!--[if !vml]>
<span style="mso-ignore:vglayout;position:absolute;z-index:252065792;margin-left:371px;margin-top:154px;width:645px;height:1px">
  <img width="430" height="1" style="width:4.4791in;height:.0069in" src="cid:image068.jpg@01D9A2AD.C8D53C40" v:shapes="Picture_x0020_2074">
</span>
<![endif]-->

This html is parsed as a 2 independent comment nodes and all internal content appears as a valid active html:

<![if !vml]>
<span style="mso-ignore:vglayout;position:absolute;z-index:252065792;margin-left:371px;margin-top:154px;width:645px;height:1px">
  <img width="430" height="1" style="width:4.4791in;height:.0069in" src="cid:image068.jpg@01D9A2AD.C8D53C40" v:shapes="Picture_x0020_2074">
</span>
<![endif]>

When we serialize it back the parser adds comments around these VML tags and the html is rendered different in the Outlook Windows Desktop client. The <![if !vml]> is converted to the <!--[if !vml]--> and the <![endif]> is converted to the <!--[endif]-->.

This is the code example:

const parse5 = require("parse5");
let doc = parse5.parse(`<!DOCTYPE html><html><body><![if !vml]>
<span style="mso-ignore:vglayout;position:absolute;z-index:252065792;margin-left:371px;margin-top:154px;width:645px;height:1px">
  <img width="430" height="1" style="width:4.4791in;height:.0069in" src="cid:image068.jpg@01D9A2AD.C8D53C40" v:shapes="Picture_x0020_2074">
</span>
<![endif]></body></html>`);
let res = parse5.serialize(doc);

The resulted serialized html should look the same as the original one.
Opened after: cure53/DOMPurify#819
@markb-trustifi markb-trustifi mentioned this issue Aug 2, 2023
Closed
@dead-claudia
Copy link

The behavior you're seeing with the two separate comment nodes is technically required per spec: https://html.spec.whatwg.org/multipage/parsing.html#parse-error-incorrectly-opened-comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dead-claudia @markb-trustifi