Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support dev server running on https #433

Open
flash716 opened this issue Apr 25, 2023 · 2 comments
Open

Support dev server running on https #433

flash716 opened this issue Apr 25, 2023 · 2 comments
Assignees
Labels
feature New feature or request

Comments

@flash716
Copy link

Is your feature request related to a problem? Please describe.
I run my development environment using https as I deal with lots of OAuth providers that require https, even in development. It appears that the inngest development server discovers the service successfully when passing the url when starting the server npx inngest-cli@latest dev -u https://dev.mydomain.com:3000/api/inngest. This is great. However, when events are executed the POST to my dev server uses http instead of https.

1:06PM INF executor > executing action action_name=step dsn=my-id-test-step-step-test run_id=01GYX0DC6VP2Z5QZET4HZMAVGC scopes=null step=step version=null
1:06PM WRN executor > error executing step error="error executing action: Post \"http://dev.mydomain.com:3000/api/inngest?fnId=my-id-test&stepId=step\": EOF" attempt=0 edge={"incoming":"step","outgoing":"$trigger"} fn_id=my-id-test fn_name=Test retryable=true run_id=01GYX0DC6VP2Z5QZET4HZMAVGC step=step
1:06PM WRN requeuing job error="error executing action: Post \"http://dev.mydomain.com:3000/api/inngest?fnId=my-id-test&stepId=step\": EOF" at_ms=1682453213431

Describe the solution you'd like
Ideally the inngest development server would post the requests to https if the url passed to inngest-cli -u is https.

It also took me a while to figure out this was the issue as the inngest dev server started fine and I was able to send events to it, they just never attempted to run. If https cannot be supported then having the dev server throw some sort of error would have saved me some time.

Describe alternatives you've considered
For the time being I've set up express to serve my app on both https(port 3000) and http(port 3001) and passing the http url when starting the server. This appears to work fine but is not ideal.

@flash716 flash716 added the feature New feature or request label Apr 25, 2023
IGassmann pushed a commit that referenced this issue Feb 14, 2024
@xavimb
Copy link

xavimb commented Mar 6, 2024

I'm having the same issue. This makes development cumbersome, as now Next.js has built-in https support.

@samishal1998
Copy link

I have the opposite issue actually, It's only sending to https while my next.js is running on http

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants