Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inngest dev Force normal output (disable --json) #810

Open
albinekb opened this issue Nov 5, 2023 · 2 comments
Open

inngest dev Force normal output (disable --json) #810

albinekb opened this issue Nov 5, 2023 · 2 comments
Assignees
Labels
feature New feature or request

Comments

@albinekb
Copy link

albinekb commented Nov 5, 2023

Is your feature request related to a problem? Please describe.
We are using turbo repo, and I set up a simple package in our monorepo to start the inngest dev server as part of our other dev commands:

  "scripts": {
    "dev": "inngest dev"
  }

When turbo runs the dev command, it seems that inngest CLI detects it as a non-TTY, thus enabling --json flag:

inngest-dev:dev: {"level":"info","caller":"runner","backend":"redis","time":"2023-11-05T14:19:08+01:00","message":"starting event stream"}
inngest-dev:dev: {"level":"info","caller":"runner","time":"2023-11-05T14:19:08+01:00","message":"service starting"}
inngest-dev:dev: {"level":"info","caller":"executor","time":"2023-11-05T14:19:08+01:00","message":"service starting"}
inngest-dev:dev: {"level":"info","caller":"executor","time":"2023-11-05T14:19:08+01:00","message":"subscribing to function queue"}
inngest-dev:dev: {"level":"info","caller":"runner","topic":"events","time":"2023-11-05T14:19:08+01:00","message":"subscribing to events"}
inngest-dev:dev: {"level":"info","caller":"devserver","time":"2023-11-05T14:19:08+01:00","message":"service starting"}
inngest-dev:dev: {"level":"info","caller":"devserver","time":"2023-11-05T14:19:08+01:00","message":"autodiscovering locally hosted SDKs"}
inngest-dev:dev: {"level":"info","caller":"devserver","caller":"api","addr":"0.0.0.0:8288","time":"2023-11-05T14:19:08+01:00","message":"starting server"}

Describe the solution you'd like
I would like to have an option to force default output, eg --json false or something like that

Describe alternatives you've considered
Piping the inngest dev to something that parses the json and outputs it in regular readable text, or wrapping it in some other way to trick it into not enabling json output

@albinekb albinekb added the feature New feature or request label Nov 5, 2023
@albinekb
Copy link
Author

albinekb commented Nov 8, 2023

@colelawrence
Copy link

This is the same issue that occurs when using https://tilt.dev
I also found the problematic lines of code here
https://github.com/inngest/inngest/blob/78b73062102d7adbf2515acb092e8f52ee0c46b9/cmd/commands/root.go#L74C38-L77

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants