Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Dev server strips port from custom url when using https #842

Open
edgarrroussille opened this issue Nov 14, 2023 · 0 comments
Open

Comments

@edgarrroussille
Copy link

Describe the bug
Our local backend server runs on custom domain, https and port 444.

When providing the app url using -u https://{domain}:444/{inngest-serve-route} it strips the port and tries to connect to https://{domain}/{inngest-serve-route}.

To Reproduce
Steps to reproduce the behavior:

  1. Spin up a dev server using custom url with https and port
  2. Check http://localhost:8288/apps and see the port has been stripped from app url

Expected behavior
Using custom port on https should work without issues locally

Code snippets / Logs / Screenshots
When I try to update the app url from the dev server dashboard (http:localhost:8288), the response logs are as follows:

  • Using https : https://{domain}:444/{inngest-serve-route}
{
     "data": {
         "updateApp": {
             "url": "https://local.functions.nhost.run/v1/inngest",
             "id": "85663d96-74e6-4a09-bf3b-761e048b8a67"
         }
     }
}
  • Using http : http://{domain}:444/{inngest-serve-route}
{
     "data": {
         "updateApp": {
             "url": "http://local.functions.nhost.run:444/v1/inngest",
             "id": "85663d96-74e6-4a09-bf3b-761e048b8a67"
         }
     }
}
@jpwilliams jpwilliams transferred this issue from inngest/inngest-js Nov 14, 2023
This issue is being transferred. Timeline may not be complete until it finishes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant