Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: v1.x - PHP 8.1 compat #72

Open
1 task done
Chrico opened this issue Sep 6, 2023 · 0 comments
Open
1 task done

[Bug]: v1.x - PHP 8.1 compat #72

Chrico opened this issue Sep 6, 2023 · 0 comments
Assignees
Labels

Comments

@Chrico
Copy link
Member

Chrico commented Sep 6, 2023

Description of the bug

Right now the version 1.x of Wonolog is not compatible to PHP 8.1 and shows several deprecated notices. As an example:

Deprecated: Return type of Inpsyde\Wonolog\Processor\ProcessorsRegistry::count() should either be compatible with Countable::count(): int, or the #[\ReturnTypeWillChange] 


Deprecated: Constant Inpsyde\Wonolog\Data\FILTER_SANITIZE_STRING is deprecated in inpsyde\wonolog\src\PhpErrorController.php on line 100


Deprecated: Return type of Inpsyde\Wonolog\Handler\HandlersRegistry::count() should either be compatible with Countable::count(): int, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice

Reproduction instructions

Expected behavior

We should fix those and also make use of our reusable workflows for lint-php to detect such errors earlier for v1.x and v2.x.

Environment info

No response

Relevant log output

No response

Additional context

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants