Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs for mention mapping are unclear #1382

Open
eloquence opened this issue Apr 7, 2022 · 2 comments · May be fixed by #1805
Open

Docs for mention mapping are unclear #1382

eloquence opened this issue Apr 7, 2022 · 2 comments · May be fixed by #1805
Assignees
@apurva1112
Labels
bug

Comments

@eloquence
Copy link

eloquence commented Apr 7, 2022 •
edited

From the README:

Mentions will work only if you login to GitHub app in your Slack workspace. When you login to GitHub app with your GitHub id, we map it with your Slack id and ping you in Slack whenever you are mentioned in any of the GitHub notifications.

What does that mean exactly? How does an ordinary user "log into their GitHub app in their Slack workspace"? What instructions should we give our users to set up mentions?
@eloquence eloquence added the bug label Apr 7, 2022
@apurva1112 apurva1112 assigned apurva1112 and unassigned snankani Apr 8, 2022
@apurva1112
Copy link
Contributor

@eloquence thanks for asking.

Mentions will work only if you login to GitHub app in your Slack workspace.

Mentions will not work for users who have not connected their github account to slack account via /github signin.

When you login to GitHub app with your GitHub id, we map it with your Slack id and ping you in Slack whenever you are mentioned in any of the GitHub notifications.

We create a mapping of user's github id to slack-user id which is used to mention the user.

Also now mentions are supported only for one workspace/enterprise for a particular user. Hence the latest signin via /github signin must be done from workspace/enterprise where the user wants to see mentions. If the user still does not see mentions, please ask him/her to run /github signin and signin.

@eloquence
Copy link
Author

Thanks! I would suggest clarifying this in the README, it wasn't at all clear to me that /github signin was even a thing.

Unfortunately, given the broad permission ask to "act on the user's behalf", this is probably a no-go for our purposes - it would be nice if it was possible to map usernames in a manner that doesn't require granting this permission.

@haydn haydn linked a pull request Nov 20, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@apurva1112 apurva1112

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add signin example to mentions section haydn/slack
3 participants
@eloquence @snankani @apurva1112