Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] support for the Github "Security Managers" feature #1210

Closed
Svetlanko opened this issue Jun 29, 2022 · 11 comments · Fixed by #1371
Closed

[Feature Request] support for the Github "Security Managers" feature #1210

Svetlanko opened this issue Jun 29, 2022 · 11 comments · Fixed by #1371
Assignees
Labels
Status: Blocked Some technical or requirement is blocking the issue Type: Feature New feature or request

Comments

@Svetlanko
Copy link

are there plans to add support for a Github "Security Managers" feature?
https://docs.github.com/en/organizations/managing-peoples-access-to-your-organization-with-roles/managing-security-managers-in-your-organization

we've been configuring it manually via Github UI but would love to have it terraformed.

thank you!

@SolomonHD
Copy link

Yes, this would be a great feature.

@jeremyhayes
Copy link
Contributor

This will need support for the security managers API. Created google/go-github#2529 to track.

I'm happy to pick this up too. 👍

@kfcampbell
Copy link
Member

Thank you @jeremyhayes! You rock. Please let me know if you'd like my eyes, assistance, etc.

@nickfloyd nickfloyd added the Type: Feature New feature or request label Oct 31, 2022
@jeremyhayes
Copy link
Contributor

Quick status update. The necessary change in the underlying API client was merged.

Now waiting on a release of that lib and for it to get updated here.

@kfcampbell
Copy link
Member

Thanks for the update! Still waiting on a release of go-github unfortunately.

@SolomonHD
Copy link

Love seeing the progress @jeremyhayes! When this is added where will this option be controlled from, github_organization_settings? Or will a new resource be created?

@jeremyhayes
Copy link
Contributor

Love seeing the progress @jeremyhayes! When this is added where will this option be controlled from, github_organization_settings? Or will a new resource be created?

My WIP has it as a new resource: github_organization_security_manager. But certainly that's up for debate when the PR opens! 😅

@jeremyhayes
Copy link
Contributor

jeremyhayes commented Nov 15, 2022

go-github v48.1.0 has released with the needed API support.

@kfcampbell what's the preferred update path here? Looks like we're still on v47. incorrect, my fork is out of date 🙃

@nickfloyd
Copy link
Contributor

Hey @jeremyhayes, I'm on it... I'll update the dep and drop a PR (reference it here).

@nickfloyd nickfloyd added the Status: Blocked Some technical or requirement is blocking the issue label Nov 16, 2022
@nickfloyd
Copy link
Contributor

For reference: go-github version update PR

@Svetlanko
Copy link
Author

thank you for getting this feature out 🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Blocked Some technical or requirement is blocking the issue Type: Feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants