Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Autolinks with alphanumeric or numeric IDs #1270

Closed
douglascayers opened this issue Sep 1, 2022 · 1 comment · Fixed by #1314
Closed

Support Autolinks with alphanumeric or numeric IDs #1270

douglascayers opened this issue Sep 1, 2022 · 1 comment · Fixed by #1314

Comments

@douglascayers
Copy link
Contributor

douglascayers commented Sep 1, 2022

GitHub updated their autolink feature to support either alphanumeric or numeric IDs.

This is a request to update the github_repository_autolink_reference resource to support the new is_alphanumeric: boolean argument, which indicates whether this autolink reference matches alphanumeric characters. If false, this autolink reference is a legacy autolink that only matches numeric characters.

Example API Payload:

{
  "id": 1,
  "key_prefix": "TICKET-",
  "url_template": "https://example.com/TICKET?query=<num>",
  "is_alphanumeric": true
}

I'm interested in working on adding this feature, and I've already submitted google/go-github#2450 to add this feature into go-github lib so that we can make use of it in this terraform plugin.

I'm a complete go novice, so I'm thankful 99% of the work for calling this API is already done 😅

Thanks!

@Djiit
Copy link

Djiit commented Sep 29, 2022

Hey team,

Interested in this too. Happy to pair/collaborate on it; but same, would need a bit of guidance to start.

kfcampbell pushed a commit that referenced this issue Oct 31, 2022
* Add `is_alphanumeric` for repo autolinks

* Test `is_alphanumeric` for repo autolinks

* Use parseTwoPartID util func for consistent import ids

* Update docs about `is_alphanumeric` and import format

* revert import state parsing to avoid breaking change

* revert import state parsing to avoid breaking change

* revert import state parsing to avoid breaking change
kfcampbell added a commit that referenced this issue Oct 31, 2022
kazaker pushed a commit to auto1-oss/terraform-provider-github that referenced this issue Dec 28, 2022
…#1270) (integrations#1314)

* Add `is_alphanumeric` for repo autolinks

* Test `is_alphanumeric` for repo autolinks

* Use parseTwoPartID util func for consistent import ids

* Update docs about `is_alphanumeric` and import format

* revert import state parsing to avoid breaking change

* revert import state parsing to avoid breaking change

* revert import state parsing to avoid breaking change
avidspartan1 pushed a commit to avidspartan1/terraform-provider-github that referenced this issue Feb 5, 2024
…#1270) (integrations#1314)

* Add `is_alphanumeric` for repo autolinks

* Test `is_alphanumeric` for repo autolinks

* Use parseTwoPartID util func for consistent import ids

* Update docs about `is_alphanumeric` and import format

* revert import state parsing to avoid breaking change

* revert import state parsing to avoid breaking change

* revert import state parsing to avoid breaking change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants