Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Support Custom Roles for Users #1334

Closed
alexlo03 opened this issue Oct 18, 2022 · 5 comments · Fixed by #1369
Closed

Feature Request: Support Custom Roles for Users #1334

alexlo03 opened this issue Oct 18, 2022 · 5 comments · Fixed by #1369
Labels
Status: Up for grabs Issues that are ready to be worked on by anyone Type: Feature New feature or request

Comments

@alexlo03
Copy link

Teams allow custom role assignment: #1038 (see also #988)
Users (Collaborators) do not:

ValidateFunc: validateValueFunc([]string{"pull", "triage", "push", "maintain", "admin"}),

Thanks

@kfcampbell
Copy link
Member

@alexlo03 does that cover the functionality for custom roles described in the docs here?

@alexlo03
Copy link
Author

@kfcampbell This impacts the ability to assign the role.
With terraform now it is possible to set MY_CUSTOM_ROLE on SOME_TEAM.
It is NOT possible to set MY_CUSTOM_ROLE on SOME_PERSON.

@kfcampbell
Copy link
Member

@alexlo03 I think I understand that. Will removing the ValidateFunc you linked allow custom roles as described in the docs link above? Is that something you'd like to try submitting a PR for?

@nickfloyd nickfloyd added Type: Feature New feature or request Status: Triage This is being looked at and prioritized labels Oct 31, 2022
@alexlo03
Copy link
Author

Sorry I am unable to do a PR any time soon. Feel free to close.

@kfcampbell kfcampbell added Status: Up for grabs Issues that are ready to be worked on by anyone and removed Status: Needs info Full requirements are not yet known, so implementation should not be started labels Nov 10, 2022
@kfcampbell
Copy link
Member

I think it's still worth keeping the issue open for now in case another community members wants to give it a shot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Up for grabs Issues that are ready to be worked on by anyone Type: Feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants