Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT]: Add resources to customize OIDC subject claims #1458

Closed
1 task done
F21 opened this issue Jan 3, 2023 · 4 comments · Fixed by #1473
Closed
1 task done

[FEAT]: Add resources to customize OIDC subject claims #1458

F21 opened this issue Jan 3, 2023 · 4 comments · Fixed by #1473
Labels
Status: Up for grabs Issues that are ready to be worked on by anyone Type: Feature New feature or request

Comments

@F21
Copy link
Contributor

F21 commented Jan 3, 2023

Describe the need

I would like to be able to customize OICD subject claims for GitHub actions on a per-repo or per-organization basis.
This can be accomplished via the API, but it would be really great if we can do this in Terraform too.

Docs: https://docs.github.com/en/actions/deployment/security-hardening-your-deployments/about-security-hardening-with-openid-connect#customizing-the-subject-claims-for-an-organization-or-repository
API: https://docs.github.com/en/rest/actions/oidc#set-the-customization-template-for-an-oidc-subject-claim-for-a-repository

SDK Version

No response

API Version

No response

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@F21 F21 added Status: Triage This is being looked at and prioritized Type: Feature New feature or request labels Jan 3, 2023
@kfcampbell kfcampbell added Status: Up for grabs Issues that are ready to be worked on by anyone and removed Status: Triage This is being looked at and prioritized labels Jan 3, 2023
@kfcampbell
Copy link
Member

@F21 I agree this would be a nice feature! Do you have any interest in opening up a PR for this behavior?

@F21
Copy link
Contributor Author

F21 commented Jan 3, 2023

@kfcampbell Sure! Definitely happy to open a PR for this, but we need to get this supported in google/go-github first, so I logged google/go-github#2614

@kfcampbell
Copy link
Member

@F21 thank you! You rock.

@F21
Copy link
Contributor Author

F21 commented Jan 3, 2023

This can be implemented once google/go-github#2615 is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Up for grabs Issues that are ready to be worked on by anyone Type: Feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants