Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for configuring checks to branch protection #985

Closed
jtgrohn opened this issue Nov 24, 2021 · 6 comments
Closed

Add support for configuring checks to branch protection #985

jtgrohn opened this issue Nov 24, 2021 · 6 comments
Labels
r/branch_protection Status: Stale Used by stalebot to clean house Status: Up for grabs Issues that are ready to be worked on by anyone Type: Feature New feature or request

Comments

@jtgrohn
Copy link
Contributor

jtgrohn commented Nov 24, 2021

Affected Resource(s)

Please list the resources as a list, for example:

  • github_branch_protection
  • github_branch_protection_v3

Description

The GitHub API supports setting up checks as well as contexts for branch protection. checks provide a few more configuration options (like enforcing that a check is set by a specific app)

image

Could you add support to the github_branch_protection and github_branch_protection_v3 resources to configure checks? Currently they only support contexts

Thanks

@k24dizzle
Copy link
Contributor

I took a look at this and I believe go-github doesn't support this field yet either. So we'd have to wait for them to implement it first before we can add this to terraform provider. Created an issue in the go-github repo for this here:
google/go-github#2274

@zacharymelancon
Copy link

zacharymelancon commented Mar 30, 2022

google/go-github#2276 @k24dizzle It looks like checks was added to go-github since your last comment.

@k24dizzle
Copy link
Contributor

Yeah so this is where I left off with this: #1051
Now that it is in go-github, we could pick this work up again

@bombelme
Copy link

@k24dizzle are you planning to continue working on this?

@TheQueenIsDead
Copy link
Contributor

I have tried to kick a PR off to support this in #1415, though it looks like Github does some interesting things in the back-end (Returning a list of contexts when only checks were provided). If anyone with more experience developing plugins would like to chime in / extend this work I'd be more than happy for the help 🙏

Just want to be able to define protections again 🥲

@kfcampbell kfcampbell added Status: Up for grabs Issues that are ready to be worked on by anyone Priority: Normal labels Dec 8, 2022
Copy link

👋 Hey Friends, this issue has been automatically marked as stale because it has no recent activity. It will be closed if no further activity occurs. Please add the Status: Pinned label if you feel that this issue needs to remain open/active. Thank you for your contributions and help in keeping things tidy!

@github-actions github-actions bot added the Status: Stale Used by stalebot to clean house label Apr 21, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
r/branch_protection Status: Stale Used by stalebot to clean house Status: Up for grabs Issues that are ready to be worked on by anyone Type: Feature New feature or request
Projects
None yet
Development

No branches or pull requests

8 participants