Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Idempotency to ILP over HTTP #560

Open
gakonst opened this issue Dec 9, 2019 · 2 comments
Open

Add Idempotency to ILP over HTTP #560

gakonst opened this issue Dec 9, 2019 · 2 comments

Comments

@gakonst
Copy link
Member

gakonst commented Dec 9, 2019

We can probably add idempotent retries to the client/server of ILP over HTTP, similarly to the one in the engines.

I think this is slightly different as we cannot assume that the peer will eventually reply.

Do we retry Prepares? Fulfils? Both?

@emschwartz
Copy link
Member

This would be a protocol change so it might be worth proposing on the RFCs repo as well.

It may be possible to add this in a backwards-compatible way using headers to do the version negotiation.

Adding retries for Fulfills/Rejects is definitely more valuable, but it might be worth adding it for Prepares as well while we're at it. The benefit of being able to retry Prepares is that if the connection drops for some reason while you're waiting for the response, you could more quickly retry the request instead of waiting until the timeout to see if the peer sends you the response (indicating they got the original request).

@kincaidoneil
Copy link
Member

Opened a strawman PR to add this to the spec here, feedback welcome: interledger/rfcs#567

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants