Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking breaking changes #668

Open
koivunej opened this issue Jan 15, 2021 · 2 comments
Open

Tracking breaking changes #668

koivunej opened this issue Jan 15, 2021 · 2 comments

Comments

@koivunej
Copy link
Collaborator

koivunej commented Jan 15, 2021

While handling the latest 1.49 clippy lints in #667, there are at least two public instances of Result<_, ()> which are now nagged by clippy changing of which require a minor version bump:

Given commit 3f1a8de I had thought that 1.0.0 versions had already been pushed, but in light of us needing to make breaking changes to keep up with clippy, I'd recommend reverting the 1.0.0 bump and going ahead with the next released versions being 0.x series. crates.io doesn't have any 1.0 crates nor does dockerhub, at least as far as I can search it.

@koivunej
Copy link
Collaborator Author

koivunej commented Jan 15, 2021

As I already commented on the 667, we need a way to start marking the commits with breaking changes. I suggest conventional commits with ! in the scope and BREAKING CHANGE in the "footer". Also, we need to go back in time to find other breaking changes.

@kincaidoneil
Copy link
Member

I'd recommend reverting the 1.0.0 bump and going ahead with the next released versions being 0.x series. crates.io doesn't have any 1.0 crates nor does dockerhub, at least as far as I can search it.

Sounds good to me 👍 (personally... wasn't a big fan of that "1.0" release)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants