Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker image for ilp-node needs a HEALTHCHECK #681

Open
aphelionz opened this issue Feb 5, 2021 · 1 comment
Open

Docker image for ilp-node needs a HEALTHCHECK #681

aphelionz opened this issue Feb 5, 2021 · 1 comment

Comments

@aphelionz
Copy link
Collaborator

Due to route propagation delays, sometimes the container can appear spun up while there are still connectivity issues. It would be good if the image could report out a health check once everything is stable. This will help with k8s deployments, among other things.

@koivunej
Copy link
Collaborator

koivunej commented Apr 15, 2021

In testing code, this is currently done with repeatedly issuing GET requests, for example in examples/simple/README.md (cannot link directly): wait_to_serve "http://localhost:7700" 10.

Similarly in ilp-node benchmarks, which just re-attempts the payment until it first succeeds.

Marking this as good-first-issue as only docker knowledge is required, assuming the GET / request is enough. It would be forwards at least.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants