Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move auth's koa session state out of service #2673

Closed
BlairCurrey opened this issue Apr 23, 2024 · 0 comments · Fixed by #2693
Closed

Move auth's koa session state out of service #2673

BlairCurrey opened this issue Apr 23, 2024 · 0 comments · Fixed by #2693
Assignees
Labels
discussions: ideas Convert to an idea discussion

Comments

@BlairCurrey
Copy link
Contributor

BlairCurrey commented Apr 23, 2024

Feature Request

Describe the feature you'd like to request

Dont keep state in-memory for koa-session in auth.

Describe the solution you'd like

Use redis as external session store for koa-session in auth. https://github.com/koajs/session?tab=readme-ov-file#external-session-stores. Note that koa-session is also used in a test context, which this doesn't really need to change.

Describe alternatives you've considered

In light of discussions about migrating away from redis I also considered storing it in postgres instead. However even if we migrate away from redis, I think migrating from a redis to a redis-like service will be much simpler (probably just changing image in docker compose, no code changes) and just generally more fit for this purpose.

@BlairCurrey BlairCurrey added the discussions: ideas Convert to an idea discussion label Apr 23, 2024
@BlairCurrey BlairCurrey self-assigned this Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussions: ideas Convert to an idea discussion
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant