Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove env variable defaults #2683

Open
1 of 5 tasks
sabineschaller opened this issue Apr 30, 2024 · 0 comments
Open
1 of 5 tasks

Remove env variable defaults #2683

sabineschaller opened this issue Apr 30, 2024 · 0 comments
Assignees
Labels
breaking Issue/PR that introduces breaking changes pkg: auth Changes in the GNAP auth package. pkg: backend Changes in the backend package. pkg: documentation Changes in the documentation package. story Major feature that can be broken up into smaller tasks type: documentation Improvements or additions to documentation

Comments

@sabineschaller
Copy link
Member

sabineschaller commented Apr 30, 2024

Context

During the workweek in Cluj, we went through the list of env variables in backend and auth and changed some defaults. We also crystalized a list of variables that should not have defaults (set to none). The containers should not spin up if those variables are not set. For the local playground, we can define those in the docker-compose.

Backend defaults:

  • ENABLE_TELEMETRY: false (set to true in local playground)
  • OPEN_PAYMENTS_URL: <None>
  • ILP_ADDRESS: <None>
  • ILP_CONNECTOR_ADDRESS: <None>
  • STREAM_SECRET: <None>
    • info on how that should be generated
  • USE_TIGERBEETLE: true
  • INSTANCE_NAME: <None>
  • EXCHANGE_RATES_URL: <None>
  • AUTH_SERVER_GRANT_URL: <None>
  • AUTH_SERVER_INTROSPECTION_URL: <None>
  • WEBHOOK_URL: <None>
  • SIGNATURE_SECRET: <None>
  • KEY_ID: <None>
  • SPSP_ENABLED: True
    • Rename this to ENABLE_INTERLEDGER_PAYMENT_POINTERS

Auth defaults:

  • IDENTITY_SERVER_DOMAIN: <None>
    • Rename to IDENTITY_SERVER_URL
  • AUTH_SERVER_DOMAIN: <None>
  • Rename AUTH_SERVER_DOMAIN to AUTH_SERVER_URL
  • IDENTITY_SERVER_SECRET: <None>
    • info on how that should be generated
  • COOKIE_KEY: <None>

Todos

@sabineschaller sabineschaller added pkg: backend Changes in the backend package. pkg: auth Changes in the GNAP auth package. pkg: documentation Changes in the documentation package. type: documentation Improvements or additions to documentation breaking Issue/PR that introduces breaking changes story Major feature that can be broken up into smaller tasks labels Apr 30, 2024
@sabineschaller sabineschaller changed the title [workweek]: Remove env variable defaults Remove env variable defaults Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Issue/PR that introduces breaking changes pkg: auth Changes in the GNAP auth package. pkg: backend Changes in the backend package. pkg: documentation Changes in the documentation package. story Major feature that can be broken up into smaller tasks type: documentation Improvements or additions to documentation
Projects
Status: In Progress
Development

No branches or pull requests

2 participants