Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete an unused asset #2589

Open
JoblersTune opened this issue Mar 20, 2024 · 3 comments · May be fixed by #2699
Open

Delete an unused asset #2589

JoblersTune opened this issue Mar 20, 2024 · 3 comments · May be fixed by #2699
Assignees
@lengyel-arpad85

Comments

@JoblersTune
Copy link
Collaborator

JoblersTune commented Mar 20, 2024 •
edited by Tymmmy

Context

The goal is to be able to delete an asset if no transactions were done for it, and no wallet/account is using it.
This will involve backend checks to ensure those requirements are met (any concerns about race conditions)
Then the GraphQL query will need to be created on the backend
And the Admin UI will also need to be updated accordingly

Todos

  • [ ]
@sabineschaller
Copy link
Member

@JoblersTune @lengyel-arpad85 Can we deactivate rather than delete?

@lengyel-arpad85
Copy link
Contributor

@sabineschaller we could do a soft delete (have a time stamp for deletedAt), but then we have to make changes in more places to not display / use these, when creating a new one we would have to check if there is no asset with same code, but exclude deleted ones
also, from what I understood this is for the cases when someone creates an asset with a wrong code or scale (which aren't editable afterwards) ... what would be the benefit of keeping them ?

@lengyel-arpad85
Copy link
Contributor

@sabineschaller well, my previous comment might be mute ... seems like tigerbeetle has no support for delete (at least I could not find any), so we have no way of deleting a record outside of psql, so only way is to mark them as inactive/deleted

@lengyel-arpad85 lengyel-arpad85 linked a pull request May 3, 2024 that will close this issue
feat(2589): soft delete unused asset #2699
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lengyel-arpad85 lengyel-arpad85

Labels
None yet
Projects
Rafiki
Status: Ready for Review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(2589): soft delete unused asset interledger/rafiki
3 participants
@sabineschaller @JoblersTune @lengyel-arpad85