Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate Shared Logger Package #2707

Closed
BlairCurrey opened this issue May 7, 2024 · 1 comment · Fixed by #2724
Closed

Investigate Shared Logger Package #2707

BlairCurrey opened this issue May 7, 2024 · 1 comment · Fixed by #2724
Assignees
Labels
discussions: ideas Convert to an idea discussion

Comments

@BlairCurrey
Copy link
Contributor

Look into creating a shared logging package with to be used across our packages. May include graphql logging plugin and similar (if any). Is there a value-add there?

@BlairCurrey BlairCurrey added the discussions: ideas Convert to an idea discussion label May 7, 2024
@BlairCurrey BlairCurrey self-assigned this May 14, 2024
@BlairCurrey
Copy link
Contributor Author

BlairCurrey commented May 15, 2024

Results:

There is practically no configuration for all of our pino loggers. Basically just the level. In light of that I don't really see any value-add for making a shared logger. If in the future we ever say "ensure all of our loggers are configured in [X] way" then it would probably be a good idea to make them shared then.

However, while investigating I found a (practically) unused Logger in backend and auth. I figure I might as well address that here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussions: ideas Convert to an idea discussion
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant