Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Start monetization iframe #241

Merged
merged 8 commits into from May 17, 2024
Merged

feat: Start monetization iframe #241

merged 8 commits into from May 17, 2024

Conversation

dianafulga
Copy link
Contributor

@github-actions github-actions bot added the area: content Improvements or additions to extension content script label Apr 30, 2024
@raducristianpopa
Copy link
Member

raducristianpopa commented Apr 30, 2024 •
edited

Extension builds preview

Name Link
Latest commit cdceea5
Latest job logs Run #9128388265
BadgeDownload
BadgeDownload

@dianafulga dianafulga marked this pull request as ready for review May 1, 2024 20:20
@dianafulga dianafulga changed the title Start monetization iframe feat: Start monetization iframe May 1, 2024
@tselit tselit linked an issue May 2, 2024 that may be closed by this pull request
[Monetization flow - Content] - IFrames #233
Closed
@sublimator
Copy link
Member

Probably need to be careful of 'message' intercept. Keep an eye on this:
w3c/webextensions#12 (comment)

@github-actions github-actions bot added area: background Improvements or additions to extension background script area: popup Improvements or additions to extension popup labels May 14, 2024
@github-actions github-actions bot removed the area: background Improvements or additions to extension background script label May 17, 2024
@raducristianpopa raducristianpopa merged commit 273e664 into main May 17, 2024
7 checks passed
@raducristianpopa raducristianpopa deleted the df--iframes branch May 17, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raducristianpopa raducristianpopa raducristianpopa approved these changes

Assignees
No one assigned
Labels
area: content Improvements or additions to extension content script area: popup Improvements or additions to extension popup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Monetization flow - Content] - IFrames
3 participants
@dianafulga @raducristianpopa @sublimator