Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce logging emission for Packet rejections. #613

Open
sentry-io bot opened this issue Mar 6, 2020 · 1 comment
Open

Reduce logging emission for Packet rejections. #613

sentry-io bot opened this issue Mar 6, 2020 · 1 comment
Labels
cleanup Tasks to cleanup the project. v1.0 Features to be fixed for a 1.0 release

Comments

@sentry-io
Copy link

sentry-io bot commented Mar 6, 2020

This should just be logged as an info emission. It's not an error. We should adjust the emission to log as info if the maxPacket amount is lower than the packet; but emit warns otherise.

===

Sentry Issue: XPRING-ILP-TESTNET-10

Stacktrace (most recent call first):

    at org.interledger.connector.links.filters.OutgoingBalanceLinkFilter.lambda$doFilter$1(OutgoingBalanceLinkFilter.java:110)
    at org.interledger.core.InterledgerResponsePacket.handle(InterledgerResponsePacket.java:64)
    at org.interledger.connector.links.filters.OutgoingBalanceLinkFilter.doFilter(OutgoingBalanceLinkFilter.java:70)
    at org.interledger.connector.links.filters.DefaultLinkFilterChain.doFilter(DefaultLinkFilterChain.java:69)
    at org.interledger.connector.links.filters.OutgoingMaxPacketAmountLinkFilter.lambda$doFilter$2(OutgoingMaxPacketAmountLinkFilter.java:43)
    at java.util.Optional.orElseGet
    at org.interledger.connector.links.filters.OutgoingMaxPacketAmountLinkFilter.doFilter(OutgoingMaxPacketAmountLinkFilter.java:43)
    at org.interledger.connector.links.filters.DefaultLinkFilterChain.doFilter(DefaultLinkFilterChain.java:69)

Outgoing packet not applied due to ILP Reject. outgoingDestinationAccount=AccountSettings{accountRelationship=CHILD, assetCode=XRP, assetScale=9, customSettings={ilpOverHttp.outgoing.url=https://spsp-test.xpring.dev/ilp, ilpOverHttp.incoming.auth_type=SIMPLE, ilpOverHttp.outgoing.simple.auth_token=enc:gcpkms:connector:secret0:1:gs:CiQAxw4Qh2MH-gAwHD6RI3VdRejZj0Sonb1QW8d3LbgTtp8Som4SOQBDcjVn0nyjDf7wCr9pKOKJcik_FaYQPJ5AGNiQFqwXC1uOoa02tZvyhfOVsOPN7BQ800QjCj-odw==, ilpOverHttp.incoming.simple.auth_token=enc:gcpkms:connector:secret0:1:gs:CiQAxw4Qh1b-sOgxVWcn6KC_l_jbGWNdtpypRykkValGEexg4XsSSQBDcjVnoXvamd3IWhw8rEeZ8VPcBFnMokF9a-1zaLzOVQWdnygYhs1BUq5tbmXiSmX8zwgd-JlabfJevMIdBzWVP7EMkN-qhHc=, ilpOverHttp.outgoing.auth_type=SIMPLE}, accountId=theotherian, createdAt=2020-03-06T16:56:39.291433Z, modifiedAt=2020-03-06T16:56:39.291433Z, description=hermes account for theotherian, linkType=LinkType(ILP_OVER_HTTP), isInternal=false, isConnectionInitiator=true, ilpAddressSegment=theotherian, isSend...
@sentry-io
Copy link
Author

sentry-io bot commented Mar 6, 2020

Sentry issue: XPRING-ILP-TESTNET-18

@sappenin sappenin added this to To do in v0.6 (Cleanup + bugs) Sep 3, 2020
@sappenin sappenin added the cleanup Tasks to cleanup the project. label Sep 3, 2020
@sappenin sappenin added the v1.0 Features to be fixed for a 1.0 release label Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Tasks to cleanup the project. v1.0 Features to be fixed for a 1.0 release
Projects
Development

No branches or pull requests

1 participant