Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow CORS to be configured on SPSP and other HTTP endpoints #638

Open
sappenin opened this issue Apr 10, 2020 · 1 comment
Open

Allow CORS to be configured on SPSP and other HTTP endpoints #638

sappenin opened this issue Apr 10, 2020 · 1 comment

Comments

@sappenin
Copy link
Collaborator

We need CORS to be configurable in the Connector, especially for SPSP, but probably generally. The default should probably be */* or whatever, but we need to honor config here for proper ops deployment.

Also, see default SpringBoot functionality here - we should probably not do custom CORS if we can help it.

See https://spring.io/blog/2015/06/08/cors-support-in-spring-framework

@sappenin sappenin added the bug label Apr 10, 2020
@sappenin sappenin changed the title Allow CORS to be disabled on SPSP and other endpoints Allow CORS to be configured on SPSP and other HTTP endpoints Apr 10, 2020
@nhartner
Copy link
Collaborator

This shouldn't be necessary for Xpring wallet because we aren't doing CORS calls to the connector. We used to do CORS calls to Hermes but even that is gone because wallet calls Hermes on the same domain as the wallet (for JWT cookie sharing)

@sappenin sappenin added this to Needs triage in Bug Board Sep 3, 2020
@sappenin sappenin added this to To do in v0.6 (Cleanup + bugs) Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Bug Board
  
Needs triage
Development

No branches or pull requests

3 participants