Missing F08 max packet amount metadata

[kincaidoneil]

ilpv4-connector/connector-service-impl/src/main/java/org/interledger/connector/packetswitch/filters/MaxPacketAmountFilter.java

Lines 32 to 50 in f642e1b

	return sourceAccountSettings.maximumPacketAmount()
	// if Packet amount is greater-than `maxPacketAmount`, then Reject.
	.filter(maxPacketAmount -> sourcePreparePacket.getAmount().compareTo(maxPacketAmount) > 0)
	.map(maxPacketAmount -> {
	logger.error(
	"Rejecting packet for exceeding max amount. accountId={} maxAmount={} actualAmount={}",
	sourceAccountSettings.accountId(), maxPacketAmount, sourcePreparePacket.getAmount()
	);
	return (InterledgerResponsePacket) packetRejector.reject(
	LinkId.of(sourceAccountSettings.accountId().value()),
	sourcePreparePacket,
	InterledgerErrorCode.F08_AMOUNT_TOO_LARGE,
	String.format(
	"Packet size too large: maxAmount=%s actualAmount=%s", maxPacketAmount,
	sourcePreparePacket.getAmount())
	);
	})
	// Otherwise, the packet amount is fine...
	.orElseGet(() -> filterChain.doFilter(sourceAccountSettings, sourcePreparePacket));

Release v0.5 does appear to return any metadata in F08s; I imagine this could cause issues for legacy STREAM senders paying into it.

(My sender performs a binary search and was still able to precisely discover the max packet amount in this case 😉)

[sappenin]

Can you clarify what you mean by meta-data here?

[kincaidoneil]

Encoding the received amount and max packet amount into the data portion of the Reject packet: #260, hyperledger-archives/quilt#186

[sappenin]

Oh nice - my bad. Good catch!